-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loops by pin or pinlabel, loop color #288
base: dev
Are you sure you want to change the base?
Conversation
make visible when "hide disconnected" is active
About loop 'length' which becomes an issue with bigger connectors with loops, as the loops seem to grow with the size of the diagram (?) and start overlapping with other connecting wires as well as each other. Tried to play around setting the graphviz Tried so far:
Depending on where From this experimentation it seems that the |
I like most of these ideas. However, I feel we also need more attributes than color for each loop wire - e.g. wire entries with zero length makes no sense in the BOM. How about specifying the loop wires as a bundle of wires (with normal wire attributes)? Such a bundle could either be specified with a name together with other cables (and refer to this name from the connector) or maybe preferably directly under a |
pin
orpinlabel
Input
... results in:
Trying to link based on names that have none or more than one results when searching
connector.pins
orconnector.pinlabels
results in an error.This PR includes the newlines added in #261, output of the dev branch woudln't make any sense without that.