Skip to content

Change ckeditor5 language config propety check to handle null prototype #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change ckeditor5 language config propety check to handle null prototype #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/ckeditor5/dist/browser/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10999,8 +10999,7 @@ delete Array.prototype.__class__; // @codingStandardsIgnoreEnd
const languageObject = this.editorObject.config.get("language");
if (languageObject != null) {
if (typeof languageObject === "object") {
// eslint-disable-next-line no-prototype-builtins
if (languageObject.hasOwnProperty("ui")) {
if (Object.prototype.hasOwnProperty.call(languageObject, "ui")) {
return languageObject.ui;
}
return languageObject;
Expand Down
3 changes: 1 addition & 2 deletions packages/ckeditor5/dist/browser/index.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11001,8 +11001,7 @@
const languageObject = this.editorObject.config.get("language");
if (languageObject != null) {
if (typeof languageObject === "object") {
// eslint-disable-next-line no-prototype-builtins
if (languageObject.hasOwnProperty("ui")) {
if (Object.prototype.hasOwnProperty.call(languageObject, "ui")) {
return languageObject.ui;
}
return languageObject;
Expand Down
3 changes: 1 addition & 2 deletions packages/ckeditor5/dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/ckeditor5/src/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ export default class CKEditor5Integration extends IntegrationModel {
const languageObject = this.editorObject.config.get("language");
if (languageObject != null) {
if (typeof languageObject === "object") {
// eslint-disable-next-line no-prototype-builtins
if (languageObject.hasOwnProperty("ui")) {
if (Object.prototype.hasOwnProperty.call(languageObject, "ui")) {
return languageObject.ui;
}
return languageObject;
Expand Down