Skip to content

Fix froala buttons title translation #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix froala buttons title translation #1108

merged 1 commit into from
Jul 15, 2025

Conversation

carla-at-wiris
Copy link
Contributor

Description

Disabling any of the buttons wirisEditor or wirisChemistry on the toolbarButtons list of Froala, will crash the init of Froala. This does not happen with both buttons added to the toolbarButtons option of the Froala editor.

The issue was solved by checking that the button existed before changing it's contents.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How should be tested?

  1. Change Froala's language:
    • Uncomment the line 7 on the demos/html/froala/index.html file.
      *Uncomment the line 39 on the demos/html/froala/src/app.js file.
  2. Remove wirisEditor or wirisChemistry from the toolbarButtons on the Froala's demo js-
  3. Build and start the demo with nx build froala and nx start html-froala
  4. The demo should start without the button removed, should work as expected, and the button's title should be in Deutsch.

@carla-at-wiris carla-at-wiris self-assigned this Jul 2, 2025
@carla-at-wiris carla-at-wiris added the type:bug Something isn't working label Jul 2, 2025
@carla-at-wiris carla-at-wiris added the package:froala Issues involving the plugin for Froala 2 label Jul 2, 2025
@carla-at-wiris carla-at-wiris merged commit cc9ca2d into release/v8.13.3 Jul 15, 2025
14 checks passed
@carla-at-wiris carla-at-wiris deleted the fix/froala-buttons branch July 15, 2025 14:07
carla-at-wiris added a commit that referenced this pull request Jul 17, 2025
@carla-at-wiris
fix: Froala title buttons calculation (#1108)
fc90107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjiang-at-wiris xjiang-at-wiris xjiang-at-wiris approved these changes

@usantos-at-wiris usantos-at-wiris usantos-at-wiris approved these changes

@ncornaglia-at-wiris ncornaglia-at-wiris ncornaglia-at-wiris approved these changes

@jgonzalez-at-wiris jgonzalez-at-wiris Awaiting requested review from jgonzalez-at-wiris

Assignees

@carla-at-wiris carla-at-wiris

Labels
package:froala Issues involving the plugin for Froala 2 type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carla-at-wiris @xjiang-at-wiris @usantos-at-wiris @ncornaglia-at-wiris