Fix blocking double click event #1117
Open
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code in the integrationmodel.js line 653 blocks other plugins from getting the double click event
This code was introduced due to the development of telemetry.
This PR fixes the issue by replacing the
stopImmediatePropagation()
withpreventDefault()
, which only cancels the default browser behavior but still allows other registered event listeners to execute, so CKEditor4 and other plugins continue working normally.In this PR it's also added the image plugin to CKEditor4 demos permanently.
In this PR it was also included a bug where the devkit version was not properly updated, providing us to reliably test changes made on the devkit locally.
Type of Change
Checklist
yarn lint
to check)How should be tested?