Skip to content

Conversation

carla-at-wiris
Copy link
Contributor

@carla-at-wiris carla-at-wiris commented Sep 12, 2025

Description

The code in the integrationmodel.js line 653 blocks other plugins from getting the double click event


// Avoid creating the doublick listener more than once for each element.
event.stopImmediatePropagation();

This code was introduced due to the development of telemetry.

This PR fixes the issue by replacing the stopImmediatePropagation() with preventDefault(), which only cancels the default browser behavior but still allows other registered event listeners to execute, so CKEditor4 and other plugins continue working normally.

In this PR it's also added the image plugin to CKEditor4 demos permanently.

In this PR it was also included a bug where the devkit version was not properly updated, providing us to reliably test changes made on the devkit locally.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project ( Run yarn lint to check)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes

How should be tested?

  • Go to this branch CKEditor4 staging demo.
  • Double-click a formula and validate it works properly.
  • Insert an image (not a formula).
  • Double-click the image and validate that the image plugin is triggered and working properly.

@carla-at-wiris carla-at-wiris self-assigned this Sep 12, 2025
@carla-at-wiris carla-at-wiris added type:bug Something isn't working package:ckeditor4 Issues involving the plugin for CKEditor 4 labels Sep 12, 2025
@carla-at-wiris carla-at-wiris changed the title Fix CK4 blocking double click event Fix blocking double click event Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:ckeditor4 Issues involving the plugin for CKEditor 4 type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants