Fix froala id buttons not being dynamic #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carla-at-wiris
added
type:bug
icaparros-at-wiris
approved these changes
Oct 27, 2023
xripoll-at-wiris
force-pushed
the
KB-40561
branch
from
ab46ad2 to
df98839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Froala creates
idfor the MathType and ChemType buttons, taking into account the current instance ID. When applying the buttons hover text according to the set language, we use those IDs. This PR fixes the fact that they were static instead of dynamic, as Froala does.Steps to reproduce
#taskid 40561