Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KB-41052] Avoid error in CKEditor 4 with saveMode = base64 #874

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

xripoll-at-wiris
Copy link
Contributor

Description

A customer reported that in CKEditor 4, when setting wiriseditorsavemode = base64 (instead of the default xml), the editor throws an error when double clicking a formula, and this lead to inconsistent behaviors. Among others, formulas would randomly disappear.

This was caused by the fix of KB-34325 introduced a few months ago, which would decode the src of base64 formulas, causing the Image#fixAfterResize function of the devkit to throw an error upon unexpectedly finding a formula NOT in base64 despite wiriseditorsavemode being set to base64.

Steps to reproduce

  • Start the CKEditor 4 plugins demo for PHP, with this branch for html-integrations.
  • Modify the configuration.ini file to have wiriseditorsavemode = base64.
  • Check that you can correctly edit formulas, and no errors are displayed in the console.

You should also check that the fix introduced for KB-34325 still works, as this fix has been modified. To do that, follow the steps of #828 but with this branch.


#taskid 41052

@carla-at-wiris carla-at-wiris merged commit a3dbab9 into master Jan 24, 2024
19 of 20 checks passed
@carla-at-wiris carla-at-wiris deleted the KB-41052 branch January 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants