Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFT-740] wip: swap widget #264

Merged
merged 9 commits into from
Jan 27, 2023
Merged

[NFT-740] wip: swap widget #264

merged 9 commits into from
Jan 27, 2023

Conversation

cnasc
Copy link
Contributor

@cnasc cnasc commented Jan 11, 2023 •
edited
Loading

image

@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
v2-interface ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 3:47PM (UTC)

@cnasc cnasc changed the title wip: trying to get swap widget to work wip: swap widget Jan 12, 2023
@cnasc cnasc changed the title wip: swap widget [NFT-740] wip: swap widget Jan 27, 2023
@linear
Copy link

linear bot commented Jan 27, 2023

NFT-740 Eng: swap page

Update with Impact Projection as fieldset on swap page

image.png

Impact Projection:

image.png

Interest rate updates lag swaps due to the use of time-weighted values. Rates are modeled as if the price after the swap were to hold for 10 minutes.

NFT-808 🥁

Add Uniswap widget to /swap

IGNORE 👇

Include swap fee and current + projected Contract APR

image.png

Hovering on Current or Projected Target/Market lines shows tooltip:

(this is updated from our current Target/Market tooltip, and should update everywhere)

image.png

This version does a better job of intuitively showing [target] over [market] and interpreting what the relationship implies. When T/M > 1, conditionally show different guidance (…higher, …from borrowers, …charging)

image.png

Target being higher than Market means there is excess demand from borrowers, so the contract is charging borrowers  and raising interest rates.

adamgobes
adamgobes reviewed Jan 27, 2023
View reviewed changes
package.json
@@ -43,11 +44,13 @@
"ethereumjs-util": "^7.1.5",
"ethers": "5.7.2",
"graphql": "16.3.0",
"jotai-immer": "^0.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to include this in deps? noticed its not imported anywhere, same with qs below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: Uniswap/widgets#374

@cnasc cnasc merged commit fd3a3dd into main Jan 27, 2023
@cnasc cnasc deleted the cjn/swap branch January 27, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgobes adamgobes adamgobes approved these changes

@wilsoncusack wilsoncusack Awaiting requested review from wilsoncusack wilsoncusack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnasc @adamgobes