-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFT-740] wip: swap widget #264
Conversation
cnasc
commented
Jan 11, 2023
•
edited
Loading
edited
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NFT-740 Eng: swap page
Update with Impact Projection as fieldset on swap page Impact Projection:
NFT-808 🥁 Add Uniswap widget to IGNORE 👇 Include swap fee and current + projected Contract APR Hovering on Current or Projected Target/Market lines shows tooltip: (this is updated from our current Target/Market tooltip, and should update everywhere) This version does a better job of intuitively showing [target] over [market] and interpreting what the relationship implies. When T/M > 1, conditionally show different guidance (…higher, …from borrowers, …charging)
|
@@ -43,11 +44,13 @@ | |||
"ethereumjs-util": "^7.1.5", | |||
"ethers": "5.7.2", | |||
"graphql": "16.3.0", | |||
"jotai-immer": "^0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to include this in deps? noticed its not imported anywhere, same with qs below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: Uniswap/widgets#374