Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS HMR is broken on 2.7.2 #7529

Closed
1 task done
jojojojojoj5564656465465 opened this issue Jun 30, 2023 · 7 comments · Fixed by #7565
Closed
1 task done

CSS HMR is broken on 2.7.2 #7529

jojojojojoj5564656465465 opened this issue Jun 30, 2023 · 7 comments · Fixed by #7565
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) feat: hmr Related to HMR (scope)

Comments

@jojojojojoj5564656465465

What version of astro are you using?

2.7.2

Are you using an SSR adapter? If so, which one?

no

What package manager are you using?

pnpm

What operating system are you using?

linux

What browser are you using?

edge, vivaldi

Describe the Bug

When i am in dev mode, the hot reload is not working for css. It's works for html but not on css even if it's tailwind class or css in file.

What's the expected result?

i want to be abble to use dev mode and have css compile along the html

Link to Minimal Reproducible Example

https://stackblitz.com/github.com/jojojojojoj5564656465465/astro-bug2

Participation

  • I am willing to submit a pull request for this issue.
@natemoo-re natemoo-re added - P4: important Violate documented behavior or significantly impacts performance (priority) feat: hmr Related to HMR (scope) - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) and removed - P4: important Violate documented behavior or significantly impacts performance (priority) labels Jun 30, 2023
@natemoo-re natemoo-re changed the title no hot reaload CSS HMR is broken on 2.7.2 Jun 30, 2023
@matthewp matthewp self-assigned this Jun 30, 2023
@Dunqing
Copy link

Dunqing commented Jul 1, 2023

There is the same problem in UnoCSS, a related issue in #2812.

I did some research and guessed that it was broken in #7381. Hope it helps astro to fix this.

@delucis
Copy link
Member

delucis commented Jul 4, 2023

Noting that we’ve also seen reports of this with Astro v2.7.1 so may have been introduced before 2.7.2.

@jojojojojoj5564656465465
Copy link
Author

I used my unocss config on qwik and didn't get those bugs so I don't blame unocss

@delucis
Copy link
Member

delucis commented Jul 4, 2023

I’ve definitely seen similar reports for a range of set-ups with/without UnoCSS, so yeah, don’t think that’s the issue here. I’d recommend anyone who’s hitting this downgrades to astro v2.7.0 for now:

@jojojojojoj5564656465465
Copy link
Author

jojojojojoj5564656465465 commented Jul 4, 2023

I’ve definitely seen similar reports for a range of set-ups with/without UnoCSS, so yeah, don’t think that’s the issue here. I’d recommend anyone who’s hitting this downgrades to astro v2.7.0 for now:

I downgrade to 2.7.0 and it 's working perfectly

@gjaynes-squiz
Copy link

FYI, I'm getting this too with Tailwind CSS, I'm not using UnoCSS.

It's particularly bad when saving .mdx file inside a content collection.

I downgraded to 2.7.0 and it seems to fix the issue.

@florivdg
Copy link

florivdg commented Jul 5, 2023

It's particularly bad when saving .mdx file inside a content collection.

I can definitely replicate that! I'm using Tailwind CSS and .mdx files, but this combination is proving to be not working as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) feat: hmr Related to HMR (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants