Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Astro to 2.7.0 to avoid new users hitting CSS HMR bugs #302

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jul 4, 2023

What kind of changes does this PR include?

  • Something else!

Description

#301 bumped Astro in the starter template and dev dependencies to 2.7.3, but versions ≥2.7.1 have a dev bug with CSS and HMR (see withastro/astro#7529)

This PR pins those back down to 2.7.0 where that’s not an issue to ensure a smooth dev experience in this repo and for new Starlight users trying things out.

No Starlight release or changeset needed as this is purely for local dev dependencies and for people cloning the starter template.

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

⚠️ No Changeset found

Latest commit: 5509907

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 5509907
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64a43108b7eda20008ab124f
😎 Deploy Preview https://deploy-preview-302--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jul 4, 2023
@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 13.16 KB (0%)
/_astro/*.js 16.22 KB (0%)
/_astro/*.css 8.46 KB (0%)

@delucis delucis merged commit 1890363 into main Jul 4, 2023
@delucis delucis deleted the chris/pin-astro-2dot7 branch July 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants