Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbo test dependsOn #10329

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Update turbo test dependsOn #10329

merged 2 commits into from
Mar 5, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 5, 2024

Changes

ref: withastro/adapters#411

turbo run test should now re-execute integration tests correctly if Astro core is updated. CI times may take longer now whenever we make changes to Astro core, but this is technically more accurate.

Also updated turbo to latest.

Testing

Ran pnpm test locally and inspected the turbo test relationship graph

Docs

n/a

Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: d33b66f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 5, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good to me, but I would like to hear @natemoo-re and @matthewp opinions first

@ematipico ematipico merged commit 8526ca3 into main Mar 5, 2024
13 checks passed
@ematipico ematipico deleted the turbo-test-dep branch March 5, 2024 15:16
peng added a commit to peng/astro that referenced this pull request Mar 6, 2024
* main:
  [ci] release (withastro#10337)
  Revert bad release (withastro#10336)
  [ci] release (withastro#10332)
  add missing changeset (withastro#10335)
  [ci] set `--tag` on release (withastro#10323)
  [ci] format
  add back data loss confirmation handling (withastro#10330)
  [ci] format
  fix(rendering): allow render instructions to propagate while rendering slots (withastro#10316)
  [ci] format
  fix: fixed an error in the vue component editor (withastro#10293)
  chore(vercel): update @vercel/nft (withastro#10305)
  Update turbo test dependsOn (withastro#10329)
  Add minimal @astrojs/db readme (withastro#10331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants