Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve astro:env docs #11653

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

florian-lefebvre
Copy link
Member

Changes

N/A

Testing

N/A

Docs

Yes

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 56b72df

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Aug 8, 2024
*
* The `astro:env` API lets you configure a type-safe schema for your environment variables, and indicate whether they should be available on the server or the client. Import and use your defined variables from the appropriate `/client` or `/server` module:
*
* ```astro
* ---
* import { APP_ID } from "astro:env/client"
* import { API_URL, API_TOKEN, getSecret } from "astro:env/server"
* const NODE_ENV = getSecret("NODE_ENV")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes getSecret from the first snippet so that people do not assume it's the only way to access them (+ it's an advanced uscase)

* })
* ---
*
* <script>
* import { API_URL } from "astro:env/client"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also showing in a client script so users understand a client var can be accessed on both client and server

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for updating @florian-lefebvre ! 🥳

.changeset/early-experts-retire.md Outdated Show resolved Hide resolved
@florian-lefebvre florian-lefebvre merged commit 32be549 into main Aug 8, 2024
5 checks passed
@florian-lefebvre florian-lefebvre deleted the chore/improve-env-secrets-docs branch August 8, 2024 12:34
@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants