Fix vue resetting state when using view transition persistence #11946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf17ff8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: vue
matthewp
reviewed
Sep 9, 2024
packages/integrations/vue/client.js
Outdated
| } else { | ||
| appInstance.props = props; | ||
| appInstance.slots = slots; | ||
| appInstance.app._instance.proxy.$forceUpdate(); |
There was a problem hiding this comment.
is this how you're supposed to trigger an update? If this is private code we shouldn't do it, and try to find another way.
There was a problem hiding this comment.
I checked again and found a better way to call the $forceUpdate method (which is documented), so I don't think there is any private implementation details used any more.
matthewp
approved these changes
Sep 17, 2024
Merged
This was referenced Sep 18, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change keeps track of all initialized vue islands in order to update the existing instance rather than creating a new app, which resets the state.
I'm by no means a Vue expert and there might be more elegant ways to achieve this. I tried to follow the approach of the React implementation (using a
WeakMap), however, patching the props is a bit more difficult than in in React. I'm happy to improve it in case anybody has a better idea.This fixes #11854,
Testing
E2E test was added.
Docs
As this is only a fix, I don't think documentation is needed. However, it could be pointed out that state persistence is currently broken for all frameworks except for React and Vue if I'm not mistaken.