fix: add refresh context to schema for loader args #11960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5a0043 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ascorbic
commented
Sep 10, 2024
Comment on lines
+90
to
+93
| assert.ok( | ||
| json.probes.every(({ id }) => !id.startsWith('voyager')), | ||
| 'Voyager probes should not be included', | ||
| ); |
There was a problem hiding this comment.
Unrelated test that was flaky because the collection order was undefined
florian-lefebvre
approved these changes
Sep 10, 2024
|
!preview refresh-fix |
matthewp
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
refreshContextDatavalue was missing from the schema for loader args, meaning it was being stripped from the context objectTesting
Added a test
Docs