Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prerender option from injectRoute #11978

Closed
wants to merge 5 commits into from
Closed

Remove prerender option from injectRoute #11978

wants to merge 5 commits into from

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 12, 2024 •
edited
Loading

Changes

  • Removes prerender from injectRoute
  • Removes handling of deprecated entryPoint

Testing

Should still pass

Docs

withastro/docs#9388

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: eddc5bc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) docs pr semver: major Change triggers a `major` release labels Sep 12, 2024
github-actions[bot]
github-actions bot requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre mentioned this pull request Sep 12, 2024
Merged
sarah11918
sarah11918 reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @florian-lefebvre - see if what I've got in the integrations guide works for you!

.changeset/two-beans-try.md Outdated Show resolved Hide resolved
matthewp
matthewp approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

Fryuni
Fryuni approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious

@florian-lefebvre
Copy link
Member Author

The errors are (it concerns both actions and web vitals) caused by the fact that, after building the endpoint from ts to js, export const prerender is turned into const prerender; export { prerender }. Not sure what we should do about that

@florian-lefebvre
Copy link
Member Author

We'll keep the prerender option and document as "use this if Astro can't detect your prerender export". And in the future maybe we can look into improving the detection in a non-breaking way

@florian-lefebvre florian-lefebvre deleted the route-prerender branch September 13, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@github-actions GitHub Actions GitHub Actions requested changes

@matthewp matthewp matthewp approved these changes

@Fryuni Fryuni Fryuni approved these changes

Assignees
No one assigned
Labels
docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florian-lefebvre @matthewp @sarah11918 @Fryuni