Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): add support for shiki option langAlias #12039

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .changeset/dirty-socks-sip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
'@astrojs/markdown-remark': minor
'astro': minor
---

Adds a [`markdown.shikiConfig.langAlias` option](https://shiki.style/guide/load-lang#custom-language-aliases) that allows aliasing a non-supported code language to a known language.

For example, the below configuration tells shiki to highlight `cjs` code blocks using the `javascript` syntax highlighter:

```js
import { defineConfig } from 'astro/config';

export default defineConfig({
markdown: {
shikiConfig: {
langAlias: {
cjs: 'javascript',
},
},
},
});
```

````md
```cjs
'use strict';

function commonJs() {
return 'I am a commonjs file';
}
```
````
4 changes: 4 additions & 0 deletions packages/astro/src/core/config/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ export const AstroConfigSchema = z.object({
return langs;
})
.default([]),
langAlias: z
.record(z.string(), z.string())
.optional()
.default(ASTRO_CONFIG_DEFAULTS.markdown.shikiConfig.langAlias!),
florian-lefebvre marked this conversation as resolved.
Show resolved Hide resolved
theme: z
.enum(Object.keys(bundledThemes) as [BuiltinTheme, ...BuiltinTheme[]])
.or(z.custom<ShikiTheme>())
Expand Down
1 change: 1 addition & 0 deletions packages/markdown/remark/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const markdownConfigDefaults: Required<AstroMarkdownOptions> = {
themes: {},
wrap: false,
transformers: [],
langAlias: {},
},
remarkPlugins: [],
rehypePlugins: [],
Expand Down
13 changes: 9 additions & 4 deletions packages/markdown/remark/src/shiki.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,30 @@ export async function createShikiHighlighter({
defaultColor,
wrap = false,
transformers = [],
langAlias = {},
}: ShikiConfig = {}): Promise<ShikiHighlighter> {
theme = theme === 'css-variables' ? cssVariablesTheme() : theme;

const highlighter = await getHighlighter({
langs: ['plaintext', ...langs],
langAlias,
themes: Object.values(themes).length ? Object.values(themes) : [theme],
});

return {
async highlight(code, lang = 'plaintext', options) {
const resolvedLang = langAlias[lang] ?? lang;
const loadedLanguages = highlighter.getLoadedLanguages();

if (!isSpecialLang(lang) && !loadedLanguages.includes(lang)) {
if (!isSpecialLang(lang) && !loadedLanguages.includes(resolvedLang)) {
try {
await highlighter.loadLanguage(lang as BundledLanguage);
await highlighter.loadLanguage(resolvedLang as BundledLanguage);
} catch (_err) {
const langStr =
lang === resolvedLang ? `"${lang}"` : `"${lang}" (aliased to "${resolvedLang}")`;
// eslint-disable-next-line no-console
console.warn(
`[Shiki] The language "${lang}" doesn't exist, falling back to "plaintext".`,
`[Shiki] The language ${langStr} doesn't exist, falling back to "plaintext".`,
);
lang = 'plaintext';
}
Expand Down Expand Up @@ -121,7 +126,7 @@ export async function createShikiHighlighter({
// Add "user-select: none;" for "+"/"-" diff symbols.
// Transform `<span class="line"><span style="...">+ something</span></span>
// into `<span class="line"><span style="..."><span style="user-select: none;">+</span> something</span></span>`
if (lang === 'diff') {
if (resolvedLang === 'diff') {
const innerSpanNode = node.children[0];
const innerSpanTextNode =
innerSpanNode?.type === 'element' && innerSpanNode.children?.[0];
Expand Down
2 changes: 2 additions & 0 deletions packages/markdown/remark/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type * as mdast from 'mdast';
import type { Options as RemarkRehypeOptions } from 'remark-rehype';
import type {
BuiltinTheme,
HighlighterCoreOptions,
LanguageRegistration,
ShikiTransformer,
ThemeRegistration,
Expand Down Expand Up @@ -37,6 +38,7 @@ export type ThemePresets = BuiltinTheme | 'css-variables';

export interface ShikiConfig {
langs?: LanguageRegistration[];
langAlias?: HighlighterCoreOptions['langAlias'];
theme?: ThemePresets | ThemeRegistration | ThemeRegistrationRaw;
themes?: Record<string, ThemePresets | ThemeRegistration | ThemeRegistrationRaw>;
defaultColor?: 'light' | 'dark' | string | false;
Expand Down
28 changes: 28 additions & 0 deletions packages/markdown/remark/test/shiki.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,32 @@ describe('shiki syntax highlighting', () => {
// Doesn't have `color` or `background-color` properties.
assert.doesNotMatch(code, /color:/);
});

it('the highlighter supports lang alias', async () => {
const highlighter = await createShikiHighlighter({
langAlias: {
cjs: 'javascript',
},
});

const html = await highlighter.highlight(`let test = "some string"`, 'cjs', {
attributes: { 'data-foo': 'bar', autofocus: true },
});

assert.match(html, /data-language="cjs"/);
});

it('the markdown processsor support lang alias', async () => {
const processor = await createMarkdownProcessor({
shikiConfig: {
langAlias: {
cjs: 'javascript',
},
},
});

const { code } = await processor.render('```cjs\nlet foo = "bar"\n```');

assert.match(code, /data-language="cjs"/);
});
});
Loading