Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): add support for shiki option langAlias #12039

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .changeset/dirty-socks-sip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
---
'@astrojs/markdown-remark': minor
'astro': minor
---

Adds a configuration called https://shiki.style/guide/load-lang#custom-language-aliases, that allows a non-supported code language to a known language.

This option requires `langs` to be defined with the correct values. The option will tell shiki which language to load when mapping the alias.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging deeper into this now, it seems like a Shiki bug that requires you to specify the langs beforehand for aliases. It might be good to followup upstream later.

Copy link
Member Author

@ematipico ematipico Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the docs show that javascript is in the array

https://shiki.style/guide/load-lang#custom-language-aliases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have to. You can specify the langs upfront so that you can syntax highlight the code synchronously, but Astro doesn't do that and will always load the langs dynamically, so in practice the langs field is only for additional custom languages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that I came to peek in on this PR and I'm not sure whether this behaviour has been confirmed yet, so I'll wait to review!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good for docs review now 👍


The below example will tell shiki to highlight the code blocks `cjs` using the `javascript` syntax highlighting, The `langs` list will contain the `javascript` language.

```js
import { defineConfig } from "astro/config";

export default defineConfig({
markdown: {
shikiConfig: {
langAlias: {
cjs: "javascript"
},
langs: ['javascript']
}
}
})
```

``````md
```cjs
"use strict"

function commonJs() {
return "I am a commonjs file"
}
```
``````

Failing to define `langs` will result in an error:

```
Error [ShikiError]: Failed to parse Markdown file "undefined":
Language `cjs` not found, you may need to load it first
```
4 changes: 4 additions & 0 deletions packages/astro/src/core/config/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ export const AstroConfigSchema = z.object({
return langs;
})
.default([]),
langAlias: z
.record(z.string(), z.string())
.optional()
.default(ASTRO_CONFIG_DEFAULTS.markdown.shikiConfig.langAlias!),
florian-lefebvre marked this conversation as resolved.
Show resolved Hide resolved
theme: z
.enum(Object.keys(bundledThemes) as [BuiltinTheme, ...BuiltinTheme[]])
.or(z.custom<ShikiTheme>())
Expand Down
1 change: 1 addition & 0 deletions packages/markdown/remark/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const markdownConfigDefaults: Required<AstroMarkdownOptions> = {
themes: {},
wrap: false,
transformers: [],
langAlias: {},
},
remarkPlugins: [],
rehypePlugins: [],
Expand Down
2 changes: 2 additions & 0 deletions packages/markdown/remark/src/shiki.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,13 @@ export async function createShikiHighlighter({
defaultColor,
wrap = false,
transformers = [],
langAlias = {},
}: ShikiConfig = {}): Promise<ShikiHighlighter> {
theme = theme === 'css-variables' ? cssVariablesTheme() : theme;

const highlighter = await getHighlighter({
langs: ['plaintext', ...langs],
langAlias,
themes: Object.values(themes).length ? Object.values(themes) : [theme],
});

Expand Down
4 changes: 3 additions & 1 deletion packages/markdown/remark/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type * as mdast from 'mdast';
import type { Options as RemarkRehypeOptions } from 'remark-rehype';
import type {
BuiltinTheme,
HighlighterCoreOptions,
LanguageRegistration,
ShikiTransformer,
ThemeRegistration,
Expand Down Expand Up @@ -36,7 +37,8 @@ export type RemarkRehype = RemarkRehypeOptions;
export type ThemePresets = BuiltinTheme | 'css-variables';

export interface ShikiConfig {
langs?: LanguageRegistration[];
langs?: (LanguageRegistration | string)[];
ematipico marked this conversation as resolved.
Show resolved Hide resolved
langAlias?: HighlighterCoreOptions['langAlias'];
theme?: ThemePresets | ThemeRegistration | ThemeRegistrationRaw;
themes?: Record<string, ThemePresets | ThemeRegistration | ThemeRegistrationRaw>;
defaultColor?: 'light' | 'dark' | string | false;
Expand Down
30 changes: 30 additions & 0 deletions packages/markdown/remark/test/shiki.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,34 @@ describe('shiki syntax highlighting', () => {
// Doesn't have `color` or `background-color` properties.
assert.doesNotMatch(code, /color:/);
});

it('the highlighter supports lang alias', async () => {
const highlighter = await createShikiHighlighter({
langAlias: {
cjs: 'javascript',
},
langs: ['javascript']
});

const html = await highlighter.highlight(`let test = "some string"`, 'cjs', {
attributes: { 'data-foo': 'bar', autofocus: true },
});

assert.match(html, /data-language="cjs"/);
});

it('the markdown processsor support lang alias', async () => {
const processor = await createMarkdownProcessor({
shikiConfig: {
langAlias: {
cjs: 'javascript',
},
langs: ['javascript']
},
});

const { code } = await processor.render('```cjs\nlet foo = "bar"\n```');

assert.match(code, /data-language="cjs"/);
});
});
Loading