fix(container): apply polyfill #12042
Conversation
🦋 Changeset detectedLatest commit: 7b0af08 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
fix/container-api-polyfill
branch
from
0f3c8d2
to
4c4e7be
Compare
ematipico
force-pushed
the
fix/container-api-polyfill
branch
from
4c4e7be
to
7b0af08
Compare
| @@ -0,0 +1,3 @@ | |||
| import { applyPolyfills } from '../core/app/node.js'; | |||
There was a problem hiding this comment.
What's the reason for the separate file?
There was a problem hiding this comment.
that's because it needs to run first, even before other imports. We did that on the adapters repo as well
There was a problem hiding this comment.
ah yea, bundling. Annoying. The original file should probably be made a side effect though. We could have like a import "astro/polyfill"; thing. But I guess this is our last polyfills so, we don't care very much
There was a problem hiding this comment.
yeah that's also what i thought, probably not worth it at this point
Changes
Applies polyfill to the container API
Testing
CI should pass
Docs
N/A