Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: makes it so astro add does not set output server by default #12071

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat: makes it so astro add does not set output server by default #12071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef2747
feat: makes it so astro add does not set output server by default
Princesseuh Sep 25, 2024
35f5fc1
chore: changeset
Princesseuh Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-panthers-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': minor
---

`astro add` no longer automatically sets `output: 'server'`. Since the default value of output now allows for server-rendered pages, it no longer makes sense to default to full server builds when you add an adapter
4 changes: 0 additions & 4 deletions packages/astro/src/cli/add/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,6 @@ export function setAdapter(
});
}

if (!config.output) {
config.output = 'server';
}

switch (adapter.id) {
case 'node':
config.adapter = builders.functionCall(adapterId, { mode: 'standalone' });
Expand Down
Loading