-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-astro updates #12083
base: next
Are you sure you want to change the base?
create-astro updates #12083
Conversation
🦋 Changeset detectedLatest commit: ab9bea6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Todo:
|
// @ts-ignore | ||
export { default as Code } from './Code.astro'; | ||
// @ts-ignore | ||
export { default as Debug } from './Debug.astro'; | ||
// @ts-ignore | ||
export { default as WelcomeScreen } from './WelcomeScreen.astro'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Welcome instead of WelcomeScreen?
'create-astro': minor | ||
--- | ||
|
||
Add a question to ask the user which adapter to add. Add an `--add` flag taking a list of integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to talk about TS changes as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think --add
should be split to a separate PR to avoid blocking on this review. Sounds it like we can release that independently.
Co-authored-by: Reuben Tier <[email protected]>
@@ -0,0 +1,172 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving the original design here was smart for keeping this PR reviewable! Still, I recall that @FredKSchott wanted to use this as an opportunity to explore a new, more expressive design.
May become a blocker to make the new starter more of a feature we promote. Still on the fence whether merging this change in code structure without a redesign is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, this is on the next branch, so it would only affect new projects using the beta. Even if we merge this right now, there's plenty of time to make the new design before the actual release.
Changes
This PR includes a few changes to the experience of creating a new project in Astro:
// @ts-check
has been added to all the examples config filesastro check
is no longer enabled by default for the build commandcreate-astro
now takes a--add
flag, allowing one to add a bunch of integrations in one command.Basic example rework
The basics template has been reworked to provide a more minimal template, allowing it to serve as a mix between "Basics" and "Minimal":
.astro
, allowing one to still inspect how you'd achieve things in Astro. This component takes in a props to customise the title, still allowing for the implicit teaching of props. A very basic layout (similar to Emmet'sdoc
command) is included, both to setup basic HTML stuff and teach the user about templates / slotsTesting
Added / updated tests
Docs
We'll update the docs:tm: