Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an "Uncaught ReferenceError" inside of the @astrojs/vue package #12116

Merged
merged 7 commits into from
Oct 5, 2024
Merged

Fixed an "Uncaught ReferenceError" inside of the @astrojs/vue package #12116

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43a44b2
fix(vue): initialized the 'app' variable earlier in the client.js scr…
sammibajrami Oct 3, 2024
68e8c45
Merge branch 'withastro:main' into main
sammibajrami Oct 3, 2024
3b31ca9
Add changeset
ascorbic Oct 4, 2024
084edde
Merge branch 'main' into main
ascorbic Oct 4, 2024
caf2e94
Merge branch 'withastro:main' into main
sammibajrami Oct 5, 2024
9d39c01
fix(vue): reverted the last change and instead moved the 'astro:unmou…
sammibajrami Oct 5, 2024
becc89d
Merge branch 'main' into main
sammibajrami Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-sloths-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@astrojs/vue": patch
---

Fixes an Reference Error that occurred during client transitions
3 changes: 2 additions & 1 deletion packages/integrations/vue/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@ export default (element) =>

// keep a reference to the app, props and slots so we can update a running instance later
let appInstance = appMap.get(element);
let app = appInstance;

if (!appInstance) {
appInstance = {
props,
slots,
};
const app = bootstrap({
app = bootstrap({
name,
render() {
let content = h(Component, appInstance.props, appInstance.slots);
Expand Down
Loading