Fixed parsing of x-forwarded-* headers #12130
Open
+254
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This MR fixes parsing of
x-forwarded-*
headers such asx-forwarded-for
,x-forwarded-host
,x-forwarded-proto
andx-forwarded-port
. The current Astro version with node adapter cannot parse multiple values in these headers, for examplex-forwarded-proto: https,http
. This issue occurs when you run your Astro server behind two proxies, for example Cloudflare and then Nginx. All requests to SSR pages result in a 500 error in this case. Astro cannot be hosted with certain hosting providers because of this bug.Testing
x-forwarded-proto: https,http
" to any SSR page of Astro server with node adapter.Docs