Fixed component rerendering if there's only one renderer (solid-js) #12131
Conversation
|
github-actions
bot
added
the
pkg: astro
elite174
force-pushed
the
fix-multiple-component-rerenders
branch
from
993f55b
to
d9fba90
Compare
elite174
changed the title
elite174
changed the title
| // If there's only one renderer in the project (solid-js) | ||
| // we can skip the `check` calls and use that renderer (to not render solid component twice) | ||
| if (renderers.length === 1 && renderers[0].name === '@astrojs/solid') { | ||
| renderer = renderers[0]; | ||
| } else { |
elite174
changed the title
| break; | ||
| // If there's only one renderer in the project (solid-js) | ||
| // we can skip the `check` calls and use that renderer (to not render solid component twice) | ||
| if (renderers.length === 1 && renderers[0].name === '@astrojs/solid') { |
There was a problem hiding this comment.
because for some reason the tests fail for other frameworks. Moreover for solid it's critical to be rendered once, because solid doesn't have this "rerender" paradigm as react, preact or others.
More common solution could require much more efforts, so it should be carefully implemented. This is really easy fix which can help many people (because solid-start it's not that production-ready yet, so many people use astro+solid to get SSR), so we can do improvements step by step.
There was a problem hiding this comment.
I tried to apply the solution suggested here, but looks like it doesn't work anymore for all the frameworks.
There was a problem hiding this comment.
What tests fail? It's likely something we can fix. I don't think we should special-case one particular renderer in this case. There's nothing about this suggestion that shouldn't work everywhere.
If you could post the errors that occur when this is enabled for all renderers that would be helpful.
Changes
In this PR multiple server rerendering of the solid component is skipped if there's only one renderer in the project (solid-js).
I used only part of the solution for this issue.
If there're multiple rerenders, it should be processed in another way I suppose, but this little change can help if there's only one solid-js renderer.
Testing
Test was also added.
Docs
No need to update docs