fix(@astrojs/rss): prevent an error when pubDate is missing
#12137
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 523c1c7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Oct 7, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported in Doc repository:
pubDateis optional when generating RSS items since #9610 but if not provided an error is thrown (Invalid input (items.0.pubDate)).I have not created a ticket, but I have a minimal reproduction (just delete one of the pubDate).
Changes
pubDateinrssSchemato prevent the validation to fail whenpubDateis not included in the item.requiredwithoptionalfor the items updated in fix(rss): make title optional if description is provided #9610Testing
pnpm linkwith the minimal reproduction and the feed is now correctly generatedAll previous tests still work!
Docs
I added two different changesets since there was two issues (the doc + the bug). Otherwise, I don't think we need more documentation, the current one is already up to date.
/cc @withastro/maintainers-docs for feedback!