Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move lint rules to Biome #12145

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

ematipico
Copy link
Member

Changes

This PR turns off some eslint rules, and turns on the relative Biome rules.

The noUnsedVariables rule reports information diagnostics, so it should not bother too much. I run its respective code action (unsafe), which renamed all unused variables with an underscore e.g. el -> _el.

The no-console rule from eslint was incorrectly configured, because I ended removing a lot of suppression comments.

I also moved the configuration file to JSONC, so I could move the comments we had in the eslint configuration file.

Testing

Current CI should work

Docs

N/A

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 9664125

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico changed the title chore: move lint rules to Astro chore: move lint rules to Biome Oct 7, 2024
@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant