fix: Reflect the configuration for esbuild

[koyopro]

Changes

I modified compileAstro to reflect the settings in viteConfig.esbuild.

This change ensures that when vite.esbuild.target is specified in the Astro config, it is reflected during the compilation of Astro files. Previously, while the vite.build.target value would affect the build command output of an Astro project, it did not impact the dev command output. As a result, the esbuild target was effectively fixed to esnext. This update addresses and resolves that issue.

For example, by setting the configuration as follows, you can specify the esbuild target during the compilation of Astro files.

// astro.config.mjs
export default {
  vite: {
    esbuild: {
      target: 'es2018',
    },
  },
};

Fixes: The vite.build.target setting does not take effect in dev mode. · Issue #12655

Testing

Added tests with code that includes syntax targeted by esbuild, confirming the following two points:

• No transformation occurs if esbuild.target is not present in ViteConfig.
• Transformation occurs if esbuild.target is specified as anything other than esnext in ViteConfig.
  • Tested with esbuild.target set to es2018.

Docs

No documentation changes are necessary.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3d58791

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[koyopro]

Since the default target in esbuild is esnext, the explicit specification has been removed.
(If the user does not specify vite.esbuild in the astro config, compileProps.viteConfig.esbuild will be undefined, and the default settings of esbuild will be applied)
https://esbuild.github.io/api/#target:~:text=The%20default%20target%20is%20esnext

[codspeed-hq]

CodSpeed Performance Report

Merging #12676 will not alter performance

_{Comparing koyopro:feature/esbuild-target (3d58791) with main (e21c7e6)}

Summary

✅ 4 untouched benchmarks

[bluwy]

Works for me 👍 I don't know if we can always guarantee that the Astro TS will always be affected by vite.esbuild, since TypeScript compilation within Astro is an implementation detail, but since we had use the API for long now I think this should be fine.

[bluwy]

Can we pass the inlineConfig as a parameter of compile instead? That way we avoid passing the global around.