Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vitest to v3 beta #12876

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Bump vitest to v3 beta #12876

merged 1 commit into from
Jan 3, 2025

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 2, 2025

Changes

fix #12662

While it's still in beta, I think it's probably the best middleground to make the vitest template work ootb as its the main supported version that works with Vite 6.

Also this fixes the CI fail in main for the vitest example typecheck.

Testing

CI should pass. Also ran the test in with-vitest manually and worked.

Docs

n/a

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: b67bcaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels Jan 2, 2025
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #12876 will not alter performance

Comparing vitest-3 (b67bcaa) with main (7fb2184)

Summary

✅ 4 untouched benchmarks

@bluwy bluwy merged commit 6bbb3f5 into main Jan 3, 2025
16 of 17 checks passed
@bluwy bluwy deleted the vitest-3 branch January 3, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run vitest using examples/with-vitest with astro 5.0.3
2 participants