Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same-page transition with different query params #8042

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • When navigating we prevent same-page transition normally. But when there are search params we should treat that as a different page and have a transition.

Testing

  • Test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: e0e6645

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 11, 2023
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by LGTM

@matthewp matthewp merged commit 4a145c4 into main Aug 11, 2023
13 checks passed
@matthewp matthewp deleted the query-1 branch August 11, 2023 17:54
@astrobot-houston astrobot-houston mentioned this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants