Fix view transitions with client:only components #8727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 068e618 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Co-authored-by: Alexander Niebuhr <[email protected]>
* Improve `astro info` compatability * Update packages/astro/src/cli/info/index.ts Co-authored-by: Arsh <[email protected]> * chore: add changeset * feat(info): add copy to clipboard support on Unix machines with xclip installed --------- Co-authored-by: Arsh <[email protected]>
…tput (#8715) Co-authored-by: Emanuele Stoppa <[email protected]>
github-actions
bot
added
feat: markdown
|
Replaced by #8745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The original issue is #8114. Persistent
client:onlycomponents lose their styling on transition.This only happens with
astro dev, not withastro build.The reason was that the HTML files contained only statically generated styles, and the comparison between the old DOM and the new file removed the client-side generated styles.
Fix #8472 fixed this by attempting to identify these client-generated styles and retain them.
This caused several issues where old styles were not deleted during the transition, even though they should have been. (#8604, #8674)
Testing
Manually tested with code from #8604.
Docs
n/a, bug fix