feat(i18n): virtual module APIs #8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ematipico
changed the title
ematipico
force-pushed
the
feat/i18n-routing-normalize-names
branch
from
7746f8e
to
b019067
Compare
natemoo-re
approved these changes
Oct 20, 2023
ematipico
added a commit
that referenced
this pull request
Oct 23, 2023
ematipico
added a commit
that referenced
this pull request
Oct 30, 2023
ematipico
added a commit
that referenced
this pull request
Oct 30, 2023
ematipico
added a commit
that referenced
this pull request
Nov 1, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 7, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR aligns the name of the APIs exported by the virtual module
astro:i18nThe
*Absolute*APIs work usingsiteat the moment. Their behaviour will change once we will implement the domain support.I will tackle
getCurrentLocalelater. It may require more information that we don't currently have, infra speaking.Testing
I added new test case and I tested the APIs locally using a pet project
Docs
N/A for now