Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores: Tidying up the view transition router #8889

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Chores: Tidying up the view transition router #8889

merged 4 commits into from
Oct 24, 2023

Conversation

martrapp
Copy link
Member

@martrapp martrapp commented Oct 22, 2023

Changes

Chores: View transition router

  • Simplification
  • Documentation
  • Improved comprehensibility and maintainability

No changes in functionality

Testing

Small changes for less flaky executions

Docs

n/a not even a change set ;-)

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2023

⚠️ No Changeset found

Latest commit: ccd1ecc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 22, 2023
@martrapp martrapp changed the title Chores: simplifications and documentation Chores: Tidying up the view transition router Oct 22, 2023
@martrapp martrapp merged commit dbff442 into main Oct 24, 2023
13 checks passed
@martrapp martrapp deleted the mt/chores branch October 24, 2023 09:42
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
* Chores: simplifications and documentation

* improvements after review comments

* make linter happy

* More leniency with different browser behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants