-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): fallback logic of defaultLocale for i18n routing #8899
Merged
ematipico
merged 3 commits into
feat/i18n-routing
from
feat/i18-routing-fallback-default-locale
Oct 24, 2023
Merged
feat(i18n): fallback logic of defaultLocale for i18n routing #8899
ematipico
merged 3 commits into
feat/i18n-routing
from
feat/i18-routing-fallback-default-locale
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
Related to the core `astro` package (scope)
label
Oct 23, 2023
ematipico
changed the title
feat(i18n): first draft of configuration (#8607)
feat(i18n): fallback logic of defaultLocale for i18n routing
Oct 23, 2023
matthewp
approved these changes
Oct 23, 2023
ematipico
added a commit
that referenced
this pull request
Oct 30, 2023
ematipico
added a commit
that referenced
this pull request
Oct 30, 2023
ematipico
added a commit
that referenced
this pull request
Nov 1, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 7, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implement the fallback system for when
i18n.defaultLocale
andi18n.fallbackControl = "redirect"
are present in the configuration.Addresses PLT-1098
The expected behaviour is that if a user defines the
defaultLocale
to"en"
for example, then any route that has/en
in, will be redirected to a location that doesn't have/en
:/en
=>/
/en/blog/slug
=>/blog/slug
/en/getting-started
=>/getting-started
/blog/en/slug
=>/blog/slug
The fallback to the default locale assumes that the user doesn't have a folder named after the
defaultLocale
.To achieve that, here are the changes I made:
locale => RouteData[]
, essentially we group the routes via their own locale. Routes that don't belong to a locale belong to the default locale;Set
, so I can remove those routes that belong to a localefallbackFromRoutes
andfallbackToRoutes
, we now use said mapdefaultLocale
. The default locale doesn't have a prefix, so we to fallback to the root, e.g.: ifdefaultLocale
isen
, then when visitiring/it/getting-started
, we do a redirect to/getting-started
, NOT/en/getting-started
Testing
I updated the test cases based on the previous assumptions
Docs
N/A for now