[next] Update error logging #9129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3f2214 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
matthewp
reviewed
Nov 20, 2023
| 'astro': minor | ||
| --- | ||
|
|
||
| Update error log formatting |
There was a problem hiding this comment.
We like to make these changesets a paragraph or two, like what would go in a blog post.
natemoo-re
approved these changes
Nov 20, 2023
| @@ -20,7 +20,7 @@ export async function throwAndExit(cmd: string, err: unknown) { | |||
|
|
|||
| const errorWithMetadata = collectErrorMetadata(createSafeError(err)); | |||
| telemetryPromise = telemetry.record(eventError({ cmd, err: errorWithMetadata, isFatal: true })); | |||
| errorMessage = formatErrorMessage(errorWithMetadata); | |||
| errorMessage = formatErrorMessage(errorWithMetadata, true); | |||
There was a problem hiding this comment.
Non-blocking, but it'd be nice to move to an options object like { verbose: true } or { showFullStacktrace: true } to avoid an unlabelled boolean argument.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
hintto be more concise, that @Princesseuh and I had already audited together in Logging refresh #8833Result
This PR
Previously
^ didn't fit in my terminal! Once I dragged to expand and retake the screenshot:
Testing
N/A
Docs
N/A