-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server island metadata #1008
Conversation
🦋 Changeset detectedLatest commit: 36c0339 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview server-islands |
|
!preview server-islands |
|
!preview server-islands |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also create some snapshot tests in the go testing suite? It would be nice to have some safety against regressions
@ematipico this doesn't change the compiled output JS at all. It just adds the metadata that's only retrieved from the JS compiler API. That's why the tests are there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me!
Changes
server:defer
directive usage, then links that back to the import statement like what is done withclient:
islands. This information is exported as part of the compile result, on theserverComponents
field, to be used by Astro.Testing
Docs
N/A