Pass transition directives onto components #838
Conversation
🦋 Changeset detectedLatest commit: f3a4bda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| source: `<Component class="bar" transition:animate="morph"></Component>`, | ||
| filename: "/projects/app/src/pages/page.astro", | ||
| want: want{ | ||
| code: `${$$renderComponent($$result,'Component',Component,{"class":"bar","data-astro-transition-scope":($$renderTransition($$result, "", "morph", ""))})}`, |
There was a problem hiding this comment.
It's tough to understand the expected result. Are the parentheses needed in ($$renderTransition($$result, "", "morph", ""))})?
- ($$renderTransition($$result, "", "morph", ""))
+ $$renderTransition($$result, "", "morph", "")It should yield the same result
There was a problem hiding this comment.
I think our attribution expression code always wraps expressions with parens. Maybe we can change it? I don't know. I assume it's to protect against something... but what alludes me. Perhaps in case someone puts a statement inside of an expression, the parens make it into an expression? idk.
Changes
data-astro-transition-scopevar into components as well. This is needed so they can pass the result down to children, if they want.Testing
Docs