Don't ignore whitespace in expressions #930
Conversation
🦋 Changeset detectedLatest commit: 5f41338 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| clean := "" | ||
| if n.FirstChild != nil { | ||
| clean = strings.TrimSpace(n.FirstChild.Data) | ||
| } | ||
| if n.FirstChild == nil || clean == "" { |
There was a problem hiding this comment.
We now need to check for whitespace too as the parser doesn't remove them in expressions anymore.
| } else if expressionOnlyHasComment(n) { | ||
| // we do not print expressions that only contain comment blocks | ||
| return |
There was a problem hiding this comment.
Don't ignore expressions with only comments in the TSX output
There was a problem hiding this comment.
Interesting, I wonder why Nate added that check initially?
There was a problem hiding this comment.
I'm not sure, I was wondering the same as that would unexpectedly remove TS directives like @ts-ignore in this case.
Pinging @natemoo-re, maybe he could provide some background
There was a problem hiding this comment.
I honestly don't remember the context! Guessing it was just a copy + paste from the JS output which has special handling for this case.
Changes
Testing
Docs
N/A bug fix