Skip to content

Commit

Permalink
No changes to the project needed for globalRoutePriority
Browse files Browse the repository at this point in the history
  • Loading branch information
@matthewp
matthewp committed Aug 21, 2024
1 parent 07b054c commit 27026ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/content/docs/en/guides/upgrade-to/v5.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ The following features are no longer experimental in Astro v5.0:
- `actions`
- `directRenderScript` - THIS MIGHT CHANGE YOUR PROJECT NOW???? IS DEFAULT DIFFERENT? PLT-2086
- `globalRoutePriority` - THIS MIGHT CHANGE YOUR PROJECT NOW??? IS DEFAULT DIFFERENT? PLT-2087
- `globalRoutePriority`
- `rewrites`
- `env`
- `serverIslands`
Expand Down

2 comments on commit 27026ff

@sarah11918
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewp Are you sure this doesn't change any defaults on people, ever? This now prioritizes redirects and injected routes equally, whereas it didn't before. I think this does change default behaviour, and so some people's projects might be affected? (If this setting were identical to current functionality, we wouldn't have needed a flag, right?)

@Fryuni
Copy link
Member

@Fryuni Fryuni commented on 27026ff Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does change the default behavior in a way that affects people.
Especially so for people using redirects along with i18n.

Please sign in to comment.