Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify link imports in guides/imports.mdx #10451

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

trueberryless
Copy link
Contributor

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9def44
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/676418f0c0de8800080757c6
😎 Deploy Preview https://deploy-preview-10451--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 18, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/imports.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Hi @trueberryless ! Can you be sure to title this like a translation, since much of what I see proposed here has to do with changing the German language. I see one English link change, and that should really be its own PR, but it's so tiny it's fine to include it here.

@trueberryless
Copy link
Contributor Author

Hi @trueberryless ! Can you be sure to title this like a translation, since much of what I see proposed here has to do with changing the German language. I see one English link change, and that should really be its own PR, but it's so tiny it's fine to include it here.

I justed noticed as well, I didnt intend to include the German tranlation in here, git add . screwed me up...

There is already an existing PR for German translation, so I'm gonna remove the de file changes here, and leave the PR with the small change open nonetheless, if it's okay...

@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 19, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks!

@sarah11918 sarah11918 merged commit 7c40bf9 into withastro:main Dec 19, 2024
6 checks passed
@trueberryless trueberryless deleted the simplify-link-imports branch December 19, 2024 13:15
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Dec 19, 2024
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 19, 2024
…as updated, because the link is already correct.

Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt added a commit that referenced this pull request Dec 19, 2024
* i18n(fr): Update `guides/images.mdx` from #10447

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `guides/imports.mdx` from #10451 (nothing was updated, because the link is already correct.

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/images.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/images.mdx

Co-authored-by: Armand Philippot <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants