Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): document new option langAlias #9453

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ematipico
Copy link
Member

Description (required)

Adds documentation for a new shiki option called langAlias

For Astro version: 4.16.0. See astro PR #12039.

@ematipico ematipico added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f620788
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66fe7e213a49300008769b1e
😎 Deploy Preview https://deploy-preview-9453--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico ematipico changed the title feat(markdown): document new option feat(markdown): document new option langAlias Sep 20, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 20, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/markdown-content.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More options are always great! See my suggestion below!

src/content/docs/en/guides/markdown-content.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Sep 20, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918
Copy link
Member

Noting that this PR looks good, but there might be something in the upstream PR re: whether or not langs is required. And if so, that will need to go here too. (If not, then this PR is fine!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants