Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about client:only fallback slot #9516

Merged
merged 3 commits into from
Oct 2, 2024
Merged

docs: add note about client:only fallback slot #9516

merged 3 commits into from
Oct 2, 2024

Conversation

stefanprobst
Copy link
Contributor

Description (required)

adds note about fallback slot to client:only docs. copied directly from the suggestion in #8805

Related issues & labels (optional)

closes #8805

@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1194c5f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66fd28c348ddc40008786669
😎 Deploy Preview https://deploy-preview-9516--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 1, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/directives-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

apatel369
apatel369 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@apatel369 apatel369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanprobst for doing this. This is a simple yet valuable addition to the docs.

sarah11918
sarah11918 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @stefanprobst , thank you for jumping on this issue for us, and welcome to Team Docs! 🥳

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Oct 2, 2024
@sarah11918
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 

Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Arpan Patel  <[email protected]>

@sarah11918 sarah11918 merged commit 46fef5e into withastro:main Oct 2, 2024
10 checks passed
@stefanprobst stefanprobst deleted the patch-1 branch October 2, 2024 12:22
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 2, 2024
@ArmandPhilippot
i18n(fr): update reference/directives-reference.mdx
663ba1f 
See withastro#9516
@ArmandPhilippot ArmandPhilippot mentioned this pull request Oct 2, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Oct 3, 2024
Merged
yanthomasdev added a commit that referenced this pull request Oct 3, 2024
@ArmandPhilippot @yanthomasdev
i18n(fr): update reference/directives-reference.mdx (#9537)
4203f38 
See #9516

Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@apatel369 apatel369 apatel369 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add how to use a fallback slot with client:only
4 participants
@stefanprobst @astrobot-houston @sarah11918 @apatel369