Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] fix: update Vite links to use their new domain #9553

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ArmandPhilippot
Copy link
Contributor

@ArmandPhilippot ArmandPhilippot commented Oct 3, 2024

Description (required)

Vite has a new domain so I updated all the links (in all languages with Sarah's permission 😄 ) that was using vitejs.dev to use vite.dev instead. See #9548

Sorry, it seems to be more than at least somewhere. 😅 I didn't change anything other than the domain... maybe an empty line at the end of a file if there were two (auto-saving...). No big deal. I checked some links (almost all from the English version) to verify that only the domain had changed. So everything should still work!

There are still some links using the old domain. This needs to be fixed in the core repository (errors-data.ts and configuration-reference). PR ready: withastro/astro#12117

Related issues & labels (optional)

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f0f567b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66fef3725994f80008356390
😎 Deploy Preview https://deploy-preview-9553--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 3, 2024
@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de guides/environment-variables.mdx Localization changed, will be marked as complete.
de guides/imports.mdx Localization changed, will be marked as complete.
de guides/rss.mdx Localization changed, will be marked as complete.
de guides/styling.mdx Localization changed, will be marked as complete.
de guides/troubleshooting.mdx Localization changed, will be marked as complete.
de guides/typescript.mdx Localization changed, will be marked as complete.
de guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
de reference/api-reference.mdx Localization changed, will be marked as complete.
de reference/integrations-reference.mdx Localization changed, will be marked as complete.
en guides/configuring-astro.mdx Source changed, localizations will be marked as outdated.
en guides/environment-variables.mdx Source changed, localizations will be marked as outdated.
en guides/imports.mdx Source changed, localizations will be marked as outdated.
en guides/rss.mdx Source changed, localizations will be marked as outdated.
en guides/styling.mdx Source changed, localizations will be marked as outdated.
en guides/troubleshooting.mdx Source changed, localizations will be marked as outdated.
en guides/typescript.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v1.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v2.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v4.mdx Source changed, localizations will be marked as outdated.
en install-and-setup.mdx Source changed, localizations will be marked as outdated.
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
en reference/dev-toolbar-app-reference.mdx Source changed, localizations will be marked as outdated.
en reference/integrations-reference.mdx Source changed, localizations will be marked as outdated.
es guides/configuring-astro.mdx Localization changed, will be marked as complete.
es guides/environment-variables.mdx Localization changed, will be marked as complete.
es guides/imports.mdx Localization changed, will be marked as complete.
es guides/rss.mdx Localization changed, will be marked as complete.
es guides/styling.mdx Localization changed, will be marked as complete.
es guides/troubleshooting.mdx Localization changed, will be marked as complete.
es guides/typescript.mdx Localization changed, will be marked as complete.
es guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
es guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
es reference/api-reference.mdx Localization changed, will be marked as complete.
es reference/configuration-reference.mdx Localization changed, will be marked as complete.
es reference/dev-toolbar-app-reference.mdx Localization changed, will be marked as complete.
es reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
es reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
es reference/integrations-reference.mdx Localization changed, will be marked as complete.
fr guides/configuring-astro.mdx Localization changed, will be marked as complete.
fr guides/environment-variables.mdx Localization changed, will be marked as complete.
fr guides/imports.mdx Localization changed, will be marked as complete.
fr guides/rss.mdx Localization changed, will be marked as complete.
fr guides/styling.mdx Localization changed, will be marked as complete.
fr guides/troubleshooting.mdx Localization changed, will be marked as complete.
fr guides/typescript.mdx Localization changed, will be marked as complete.
fr guides/upgrade-to/v1.mdx Localization changed, will be marked as complete.
fr guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
fr guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
fr install-and-setup.mdx Localization changed, will be marked as complete.
fr reference/api-reference.mdx Localization changed, will be marked as complete.
fr reference/cli-reference.mdx Localization changed, will be marked as complete.
fr reference/configuration-reference.mdx Localization changed, will be marked as complete.
fr reference/dev-toolbar-app-reference.mdx Localization changed, will be marked as complete.
fr reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
fr reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
fr reference/integrations-reference.mdx Localization changed, will be marked as complete.
it guides/configuring-astro.mdx Localization changed, will be marked as complete.
it guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ja guides/configuring-astro.mdx Localization changed, will be marked as complete.
ja guides/environment-variables.mdx Localization changed, will be marked as complete.
ja guides/imports.mdx Localization changed, will be marked as complete.
ja guides/rss.mdx Localization changed, will be marked as complete.
ja guides/styling.mdx Localization changed, will be marked as complete.
ja guides/troubleshooting.mdx Localization changed, will be marked as complete.
ja guides/typescript.mdx Localization changed, will be marked as complete.
ja guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ja guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
ja reference/configuration-reference.mdx Localization changed, will be marked as complete.
ko guides/configuring-astro.mdx Localization changed, will be marked as complete.
ko guides/environment-variables.mdx Localization changed, will be marked as complete.
ko guides/imports.mdx Localization changed, will be marked as complete.
ko guides/rss.mdx Localization changed, will be marked as complete.
ko guides/styling.mdx Localization changed, will be marked as complete.
ko guides/troubleshooting.mdx Localization changed, will be marked as complete.
ko guides/typescript.mdx Localization changed, will be marked as complete.
ko guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ko guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
ko install-and-setup.mdx Localization changed, will be marked as complete.
ko reference/api-reference.mdx Localization changed, will be marked as complete.
ko reference/cli-reference.mdx Localization changed, will be marked as complete.
ko reference/configuration-reference.mdx Localization changed, will be marked as complete.
ko reference/dev-toolbar-app-reference.mdx Localization changed, will be marked as complete.
ko reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
ko reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
ko reference/integrations-reference.mdx Localization changed, will be marked as complete.
pl guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
pl guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
pl install-and-setup.mdx Localization changed, will be marked as complete.
pt-br guides/configuring-astro.mdx Localization changed, will be marked as complete.
pt-br guides/environment-variables.mdx Localization changed, will be marked as complete.
pt-br guides/imports.mdx Localization changed, will be marked as complete.
pt-br guides/rss.mdx Localization changed, will be marked as complete.
pt-br guides/styling.mdx Localization changed, will be marked as complete.
pt-br guides/troubleshooting.mdx Localization changed, will be marked as complete.
pt-br guides/typescript.mdx Localization changed, will be marked as complete.
pt-br guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
pt-br guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
pt-br install-and-setup.mdx Localization changed, will be marked as complete.
pt-br reference/api-reference.mdx Localization changed, will be marked as complete.
pt-br reference/configuration-reference.mdx Localization changed, will be marked as complete.
pt-br reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
pt-br reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
pt-br reference/integrations-reference.mdx Localization changed, will be marked as complete.
ru guides/environment-variables.mdx Localization changed, will be marked as complete.
ru guides/typescript.mdx Localization changed, will be marked as complete.
ru guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ru guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
ru reference/api-reference.mdx Localization changed, will be marked as complete.
ru reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
ru reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
ru reference/integrations-reference.mdx Localization changed, will be marked as complete.
zh-cn guides/configuring-astro.mdx Localization changed, will be marked as complete.
zh-cn guides/environment-variables.mdx Localization changed, will be marked as complete.
zh-cn guides/imports.mdx Localization changed, will be marked as complete.
zh-cn guides/rss.mdx Localization changed, will be marked as complete.
zh-cn guides/styling.mdx Localization changed, will be marked as complete.
zh-cn guides/troubleshooting.mdx Localization changed, will be marked as complete.
zh-cn guides/typescript.mdx Localization changed, will be marked as complete.
zh-cn guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
zh-cn guides/upgrade-to/v4.mdx Localization changed, will be marked as complete.
zh-cn install-and-setup.mdx Localization changed, will be marked as complete.
zh-cn reference/api-reference.mdx Localization changed, will be marked as complete.
zh-cn reference/cli-reference.mdx Localization changed, will be marked as complete.
zh-cn reference/configuration-reference.mdx Localization changed, will be marked as complete.
zh-cn reference/dev-toolbar-app-reference.mdx Localization changed, will be marked as complete.
zh-cn reference/errors/astro-glob-used-outside.mdx Localization changed, will be marked as complete.
zh-cn reference/errors/unknown-vite-error.mdx Localization changed, will be marked as complete.
zh-cn reference/integrations-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, oh no, this was more than I thought. But all looks good! Thank you so much. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update any Vite docs links for their new domain
3 participants