-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] fix: update Vite links to use their new domain #9553
[i18nIgnore] fix: update Vite links to use their new domain #9553
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, oh no, this was more than I thought. But all looks good! Thank you so much. 🎉
Description (required)
Vite has a new domain so I updated all the links (in all languages with Sarah's permission 😄 ) that was using
vitejs.dev
to usevite.dev
instead. See #9548Sorry, it seems to be more than
at least somewhere
. 😅 I didn't change anything other than the domain... maybe an empty line at the end of a file if there were two (auto-saving...). No big deal. I checked some links (almost all from the English version) to verify that only the domain had changed. So everything should still work!There are still some links using the old domain. This needs to be fixed in the core repository (
errors-data.ts
andconfiguration-reference
). PR ready: withastro/astro#12117Related issues & labels (optional)