fix(js/css): Fixes intellisense inside inline styles and scripts #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d329910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
force-pushed
the
fix/multibytes
branch
from
6e548df
to
969efb6
Compare
Princesseuh
added a commit
that referenced
this pull request
Jul 11, 2024
|
Superceded by #900, added the tests from this PR to it |
Princesseuh
added a commit
that referenced
this pull request
Jul 16, 2024
* fix: scripts affecting intellisense * test: add tests from #897 * feat: update compiler * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We calculate inline scripts and styles (inside HTML events and
styleattributes respectively) using the positions from the AST the compiler returns. This is fine, however the offset it returns consider multiple bytes characters, unlike LSP (well, it's in reality more complicated than that because of encoding and stuff, but it's still somewhat that)This PR changes it so we uses the Point returned instead, which do consider lines and columns character by character
Fixes #862
Testing
Added a bunch of tests
Docs
N/A