Respect Prettier's behaviour for self closing elements #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6dcdcbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
|
When can it be merged? |
When it's not blocked by the compiler issue anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prettier has a.. interesting behaviour regarding self-closing in that.. it doesn't actually respect the HTML spec...
Instead, it'll use whatever the user specified (so,
<div />will stay as is, despite being invalid HTML) unless the user hasn't explicitly closed the tag (ex:<div>), in which case it'll do whatever the spec says.Very confusing, but even more so confusing for users used to the behaviour Prettier usually has. This PR makes it so it follows Prettier's behavior.
Fix #325
Testing
Tests already cover this!
Docs
N/A