-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing whitespace from <Badge>
and <Icon>
components
#2924
base: main
Are you sure you want to change the base?
Remove trailing whitespace from <Badge>
and <Icon>
components
#2924
Conversation
🦋 Changeset detectedLatest commit: be177cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HiDeoo, thank you for making this change.
I'm still a rookie coder so I can't give any suggestions on the code, but I feel like the new style without the trailing space is nice. I hope this PR will get merged.
-snowdingo
Description
In Astro, components that include styles render with a trailing space. This behavior is not ideal for components like
<Badge>
and<Icon>
that are often used in inline text.For example, the following code:
will render as:
This PR removes the trailing space from
<Badge>
and<Icon>
components by wrapping them in a fragment which prevents the trailing space from being rendered.If we ship this change and its associated documentation change to accommodate the new behavior, we could potentially update the docs for all languages as it's purely structural changes and mark it as i18n ignored