-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
0 additions
and
164 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. May I ask why the readme is removed? @withlin
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2014BDuck hello, 因为有了example代码所以移除了README
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think other descriptions should be considered useful, guiding the entry-level users to run it. We could add a link pointing to the example file tho.
Thank you for writing this client repo. solid job.
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2014BDuck 因为之前dotnet的客户端也是我的写的,所以里面的用了那边的README的图片,如果是从canal主仓库看过来的话,其实有很多client的客户端,说明都是参考dotnet那一份,几乎一样的。所以这也是我为什么删除掉....。
BTW,你们有用到这个clinet么?
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以考虑把README加回来。
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried. But decided to use canal->kafka instead of canal->canal-client.
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果考虑全部golang项目的话,可以看看go-mysql
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would have a lot of features to implement. We are now deploying the whole thing on Kubernetes, not physical machines.
I checked
go-mysql
before, we may need to implement the HA/cluster stuff, test, and validate them. (Not sure if it's already implemented ingo-mysql
, maybe I just missed them)Canal server could be easily scaled up with Kubernetes. And for Kafka pattern, we could pass those data/binlog to various downstream with different usages (and maybe in different programming languages in the future)
72ff485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯 HA确实要自己实现,可以用etcd实现一版 HA模式。挺简单的。 canal server跑k8s 确实不错。 就是java写的会比较占内存 :). less is more~
我之前还实现了一版redis的同步,也是用的etcd。。