Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename files, contracts, variables and natspec from UniStaker to GovernanceStaker #10

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Rename files, contracts, variables and natspec from UniStaker to GovernanceStaker #10

merged 1 commit into from
Sep 23, 2024

Conversation

apbendi
Copy link
Collaborator

@apbendi apbendi commented Sep 20, 2024 •
edited
Loading

closes #3

@apbendi apbendi changed the title Rename Rename files, contracts, variables and natspec from UniStaker to GovernanceStaker Sep 20, 2024
@apbendi apbendi marked this pull request as ready for review September 20, 2024 21:11
@apbendi apbendi requested a review from alexkeating September 20, 2024 21:12
alexkeating
alexkeating approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few more uniswap references. Happy to merge this and handle those in a followup. Ultimately, up to you how you want to handle

test/GovernanceStaker.t.sol Outdated Show resolved Hide resolved
test/helpers/GovernanceStaker.handler.sol Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@apbendi @alexkeating
Rename files and variables from UniStaker to GovernanceStaker
d8049e9 
Also makes minor adjustments to CI, natspec, and other minor config changes.
@github-actions GitHub Actions
Copy link

Coverage after merging rename into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   DelegationSurrogate.sol100%100%100%100%
   GovernanceStaker.sol100%100%100%100%

@apbendi apbendi merged commit 5c73f15 into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename files and documentation to move from "UniStaker" to "Governance Staker"
2 participants
@apbendi @alexkeating