Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track total earning power by depositor #46

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Track total earning power by depositor #46

merged 1 commit into from
Oct 18, 2024

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Oct 11, 2024 •
edited
Loading

Description

  • Track total earning power by a depositor

Closes #26

@alexkeating alexkeating changed the title Features/add total earning power per depositor Track total earning power by depositor Oct 11, 2024
@alexkeating alexkeating requested a review from apbendi October 11, 2024 14:49
@alexkeating alexkeating marked this pull request as ready for review October 11, 2024 14:49
apbendi
apbendi requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we're missing updates in several methods.

src/GovernanceStaker.sol Show resolved Hide resolved
test/GovernanceStaker.t.sol Outdated Show resolved Hide resolved
src/GovernanceStaker.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the features/add-total-earning-power-per-depositor branch from 1e2afd6 to bb6624d Compare October 15, 2024 14:37
@alexkeating alexkeating mentioned this pull request Oct 16, 2024
Open
@alexkeating alexkeating requested a review from apbendi October 18, 2024 12:58
@alexkeating alexkeating force-pushed the features/add-total-earning-power-per-depositor branch from aa24a01 to e2b54f6 Compare October 18, 2024 13:00
apbendi
apbendi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @alexkeating

@apbendi apbendi force-pushed the features/add-total-earning-power-per-depositor branch from e2b54f6 to 12a21b2 Compare October 18, 2024 20:06
@github-actions GitHub Actions
Copy link

Coverage after merging features/add-total-earning-power-per-depositor into main will be

99.25%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   BinaryEligibilityOracleEarningPowerCalculator.sol100%100%100%100%
   DelegationSurrogate.sol100%100%100%100%
   GovernanceStaker.sol98.92%100%97.87%99.06%267–268

@apbendi apbendi merged commit 3918494 into main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider: Should we also track total earning power on a per-depositor basis?
2 participants
@alexkeating @apbendi