Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtract unclaimed rewards #87

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Subtract unclaimed rewards #87

merged 3 commits into from
Dec 13, 2024

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Dec 12, 2024 •
edited
Loading

Description

  • Subtract tip from unclaimed rewards when bumping

Closes #84

@github-actions GitHub Actions
Copy link

Coverage after merging fix/remove-unclaimed-rewards into main will be

98.06%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   BinaryEligibilityOracleEarningPowerCalculator.sol100%100%100%100%
   DelegationSurrogate.sol100%100%100%100%
   DelegationSurrogateVotes.sol100%100%100%100%
   GovernanceStaker.sol98.47%100%97.22%98.57%256–258
src/extensions
   GovernanceStakerDelegateSurrogateVotes.sol87.50%50%100%90.91%25–26
   GovernanceStakerOnBehalf.sol100%100%100%100%
   GovernanceStakerPermitAndStake.sol76.47%0%100%76.92%19–20, 48, 76

@alexkeating alexkeating marked this pull request as ready for review December 13, 2024 14:03
wildmolasses
wildmolasses approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexkeating alexkeating merged commit 6f11554 into main Dec 13, 2024
4 checks passed
@CergyK CergyK mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@garyghayrat garyghayrat Awaiting requested review from garyghayrat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove tip from unclaimed rewards
2 participants
@alexkeating @wildmolasses