Nonce cannot be incremented by depositor #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging fix/resolve-small-issues into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
garyghayrat
reviewed
Dec 13, 2024
| @@ -1284,7 +1283,7 @@ contract ClaimRewardOnBehalf is GovernanceStakerRewardsTest { | |||
|
|
|||
| // A user deposits staking tokens | |||
| (_depositAmount, _depositId) = | |||
| _boundMintAndStake(_depositor, _depositAmount, _delegatee, _claimer); | |||
| _boundMintAndStake(_depositor, _depositAmount, address(0x01), _claimer); | |||
There was a problem hiding this comment.
I don't understand why this change was made?
There was a problem hiding this comment.
Good question, this is to avoid a stack too deep error
garyghayrat
approved these changes
Dec 13, 2024
garyghayrat
reviewed
Dec 13, 2024
| @@ -119,6 +119,7 @@ contract BinaryEligibilityOracleEarningPowerCalculator is Ownable, IEarningPower | |||
| _setOraclePauseGuardian(_oraclePauseGuardian); | |||
| _setDelegateeScoreEligibilityThreshold(_delegateeScoreEligibilityThreshold); | |||
| _setUpdateEligibilityDelay(_updateEligibilityDelay); | |||
| lastOracleUpdateTime = block.timestamp; | |||
There was a problem hiding this comment.
could use a test here.
| @@ -761,10 +760,7 @@ abstract contract GovernanceStaker is INotifiableRewardReceiver, Multicall { | |||
| uint256 _depositNewEarningPower, | |||
| uint256 _totalEarningPower | |||
| ) internal pure returns (uint256 _newTotalEarningPower) { | |||
| if (_depositNewEarningPower >= _depositOldEarningPower) { | |||
There was a problem hiding this comment.
was this changed because of a different finding?
There was a problem hiding this comment.
Yes, it was do you think we should keep it the same?
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #85