fix(c-bridge): properly read testnet environment config from envars #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
approved these changes
Feb 6, 2025
guidiaz
force-pushed
the
c-bridge/set-testnet-environment-from-envars
branch
from
12120d4 to
b2dc053
Compare
Tommytrg
reviewed
Feb 6, 2025
| @@ -1,6 +1,7 @@ | |||
| //! Witnet <> Ethereum bridge | |||
|
|
|||
| use actix::{Actor, System, SystemRegistry}; | |||
| use witnet_data_structures::chain::Environment; | |||
There was a problem hiding this comment.
Suggested change
| use witnet_data_structures::chain::Environment; |
guidiaz
force-pushed
the
c-bridge/set-testnet-environment-from-envars
branch
from
b2dc053 to
4b5bbbb
Compare
Tommytrg
reviewed
Feb 6, 2025
Comment on lines
132
to
138
| if let Ok(config) = res { | ||
| witnet_data_structures::set_environment(if config.witnet_testnet { | ||
| Environment::Testnet | ||
| } else { | ||
| Environment::Mainnet | ||
| }); | ||
| Ok(config) | ||
| } else { | ||
| res | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Ok(config) = res { | |
| witnet_data_structures::set_environment(if config.witnet_testnet { | |
| Environment::Testnet | |
| } else { | |
| Environment::Mainnet | |
| }); | |
| Ok(config) | |
| } else { | |
| res | |
| } | |
| if let Ok(ref config) = res { | |
| witnet_data_structures::set_environment(if config.witnet_testnet { | |
| Environment::Testnet | |
| } else { | |
| Environment::Mainnet | |
| }); | |
| res | |
| } |
guidiaz
force-pushed
the
c-bridge/set-testnet-environment-from-envars
branch
from
4b5bbbb to
4130fb9
Compare
guidiaz
force-pushed
the
c-bridge/set-testnet-environment-from-envars
branch
from
4130fb9 to
9ac779f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.